Skip to content

Add OpenBLAS #385

Merged
merged 3 commits into from
Jun 1, 2017
Merged

Add OpenBLAS #385

merged 3 commits into from
Jun 1, 2017

Conversation

donald
Copy link
Collaborator

@donald donald commented May 20, 2017

Maybe we should have a BLAS library installed, seems to be very basic. See mails in helpdesk.

Copy link
Collaborator

@pmenzel pmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two typos in the commit message:

  1. When building or When (being) built

@pmenzel pmenzel changed the title Add openblas Add OpenBLAS May 21, 2017
Copy link
Collaborator

@pmenzel pmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. suggest

@@ -3,6 +3,7 @@
# BEE_VERSION OpenBLAS-0.2.19-0

BEE_BUILDTYPE=make
BEE_MAKEFLAGS="DYNAMIC_ARCH=1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+= to not override, what the user passes?

@donald
Copy link
Collaborator Author

donald commented May 23, 2017

Rebuilt to /src/mariux, didn't change revision.
D.

@pmenzel
Copy link
Collaborator

pmenzel commented May 31, 2017

I just noticed, the bee file name is not all lowercase. I’d prefer all lowercase.

# BEE_VERSION OpenBLAS-0.2.19-0

BEE_BUILDTYPE=make
BEE_MAKEFLAGS+="DYNAMIC_ARCH=1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a space be prepended? Otherwise will cause an error.

BEE_MAKEFLAGS='-j' ./OpenBLAS.be0 -c

@pmenzel
Copy link
Collaborator

pmenzel commented May 31, 2017

Lastly, do we need the static versions of the library?

@thomas
Copy link
Collaborator

thomas commented May 31, 2017

" do we need the static versions of the library? "
Shure, there are programs around that explicitly like to link statically.

When built with cmake it states

    CMake Warning at CMakeLists.txt:46 (message):
    CMake support is experimental.  This will not produce the same Makefiles
    that OpenBLAS ships with.  Only x86 support is currently available.

Also the instructions at

    https://github.com/xianyi/OpenBLAS/wiki/Installation-Guide

suggest to use plain make.
Quote https://github.com/xianyi/OpenBLAS/blob/develop/Makefile.rule:

    # If you want to support multiple architecture in one binary
    # DYNAMIC_ARCH = 1
@pmenzel pmenzel merged commit 1307de6 into master Jun 1, 2017
@pmenzel pmenzel deleted the add-openblas branch June 1, 2017 15:07
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants